[MINIFICPP-933] Raw site to site TLS bug went unnoticed in 0.6.0

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 0.7.0
• Assignee: Marc Parisi
• Reporter: Marc Parisi
• Created: 25/Jun/19 21:27
• Updated: 13/Jan/20 14:43
• Resolved: 27/Jun/19 23:10

Description

TLS bug went unnoticed until we introduced jemalloc found while running jemalloc stats and running windows tests. unit tests do not cause the problem generally but jemalloc and valgrind show the issue pretty easily. HTTP site to site isn't impacted, only Raw Site To Site. Because this is a memory issue it doesn't always fail but the error is clearly there in the code.

The initial problem first identified through building windows tests for MINIFICPP-796; however docker tests proved instrumental in finding it. I confirmed on a running instance. HTTP site to site does not use this code path, so it is not impacted.

Issue Links

• links to: GitHub Pull Request #597