[MINIFICPP-851] Restructure both client and server socket codes in Nanofi and MiNiFi

• Type: Epic
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 0.6.0
• Labels: network
• Epic Name: Restructure network sockets
• Assignee: Unassigned
• Reporter: Arpad Boda
• Created: 16/May/19 16:14
• Updated: 23/Aug/23 13:47
• Resolved: 23/Aug/23 13:47

Description

Current issues:

• MiNiFi Clientsocket and Nanofi cpeer codes have a lot in common.
• Clientsocket's implementation contain a lot of serversocket-related code.
• LystenSysLog processor has a built-in socket handling instead of using ServerSocket. 

Goals:

• MiNiFi ClientSocket should only be a wrapper around client socket implementation in Nanofi. As Nanofi impl. is platform-independent, this could make the current duplication go away, too. 
• Listen related codes (bind, accept, etc) should be moved to ServerSocket.
• Both client- and server side API should provide interface to set some socket properties (TCP/UDP, network interface, listen ip).
• ListenSysLog should depend on ServerSocket instead of having a socket implementation in the processor.
• ListenSysLog should have properties to bind only a specific interface/IP, opening syslog port on all available interfaces may raise security concerns. 

 

bakaid  phrocker please feel free to extend with your remarks.