[MINIFICPP-839] Multiple memory leaks because of shared_ptr cycles

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Duplicate
• Fix Version/s: 0.12.0
• Labels: ReloadValidation
• Assignee: Ádám Markovics
• Reporter: Dániel Bakai
• Created: 14/May/19 13:03
• Updated: 03/Feb/22 14:33
• Resolved: 03/Feb/22 14:33

Description

There seems to be a Connection<->Processor shared_ptr cycle which means that the Processors never get destructed.

This causes leaks in reloads and in tests.

There are also other cycles causing leaks:

• Connection <-> FlowFile (this seems to be partially mitigated by Connection::drain(), but not entirely)
• ResourceClaim <-> VolatileContentRepository
• VolatileContentRepository <-> VolatileContentRepository (capturing a shared_ptr into a thread func and detaching the thread)
• FlowController <- > SchedulingAgent (TimerDrivenSchedulingAgent, EventDrivenSchedulingAgent, CronDrivenSchedulingAgent) and even FlowController <- > util::ThreadPool because of this

Issue Links

• duplicates: MINIFICPP-1686 Processor destructors are not called
• is related to: MINIFICPP-1175 ControllerService neither notifyStop nor destructor is called on shutdown
• relates to: MINIFICPP-836 Validate stop and notifystop allow processors to flush
• links to: GitHub Pull Request #563