[MINIFICPP-1803] Stop instantiating all classes on the first heartbeat

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6.0, 0.9.0, 0.7.0, 0.10.0, 0.11.0, 0.12.0
• Fix Version/s: 0.13.0
• Labels: MiNiFi-CPP-Hygiene
• Assignee: Ferenc Gerlits
• Reporter: Marton Szasz
• Created: 14/Apr/22 15:24
• Updated: 23/Jun/22 12:22
• Resolved: 14/Jun/22 14:27

Description

When producing the first heartbeat, BuildDescription::getClassDescriptions instantiates every single class of each loader. In the case of AWS, the processors happen to derive from S3Processor, and they contain a data member of type Aws::Client::ClientConfiguration, whose default constructor makes HTTP calls to AWS.

The easy fix is to delay the initialization of this particular member to onSchedule.

The proper fix is to change the class loading and class description generation logic to store more metadata about classes that are collected at registration time, using compile-time introspection, instead of instantiating the classes and using dynamic_cast.

This issue is about the proper fix. For the easy fix, see MINIFICPP-1802.

Issue Links

• is related to: MINIFICPP-1802 We should not make http calls to AWS during initialization
• links to: GitHub pull request #1334