[MIME4J-258] A potential NPE

• Type: Bug
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Component/s: dom
• Assignee: Unassigned
• Reporter: JC
• Created: 23/Dec/16 01:07
• Updated: 17/May/18 09:17

Description

In dom/src/main/java/org/apache/james/mime4j/field/Fields.java, the conditions in return statement may cause NPE when 'parameters' is null. (found from a current github mirror snapshot as of cb48082fb7cbbfb111c926cc8ae953d7261c235c)

157     public static ContentTypeField contentType(String mimeType, NameValuePair... parameters) {
158         return contentType(mimeType, parameters != null || parameters.length == 0 ? Arrays.asList(parameters) : null);
159     }

Intended this?

158         return contentType(mimeType, parameters != null? Arrays.asList(parameters) : null);

Issue Links

• is duplicated by: MIME4J-276 Potential NPE in Fields.contentType(String mimeType, NameValuePair... parameters)