[METRON-771] Stellar INDEXING_SET_BATCH incorrectly defaults batchSize to 5

• Type: Bug
• Status: Done
• Priority: Major
• Resolution: Done
• Affects Version/s: 0.3.1
• Fix Version/s: 0.4.0
• Labels: backwards-incompatible

Docs Text

In 0.3.1 and prior, the implementation of Stellar function INDEXING_SET_BATCH incorrectly defaulted batch size to 5. By documentation and intent, default batch size if not specified by the user should be 1, that is disabled. In this release, INDEXING_SET_BATCH has been corrected to set default batch size to 1 if unspecified.

• Assignee: Matthew Foley
• Reporter: Matthew Foley
• Created: 16/Mar/17 20:52
• Updated: 27/Jun/17 00:08
• Resolved: 27/Mar/17 19:16

Description

The implementation of IndexingConfigFunctions::SetBatchSize() defaults batchSize to 5 for Indexing configurations. Everywhere else in code and documentation, batchSize is implemented and documented to default to 1.

Fix by changing SetBatchSize() to also default it to 1.

Marking this "backward incompatible" because it might require a change in the way users currently use INDEXING_SET_BATCH.

Issue Links

• links to: GitHub Pull Request #485