[METRON-639] The Network Stellar functions need to have better unit testing

• Type: Bug
• Status: Done
• Priority: Major
• Resolution: Done
• Fix Version/s: 0.3.1
• Assignee: Unassigned
• Reporter: Casey Stella
• Created: 21/Dec/16 23:04
• Updated: 26/Jan/17 22:45
• Resolved: 26/Jan/17 22:45

Description

We have very little unit test coverage around the Networking functions in Stellar at the edge level. When diving a bit deeper on real data, I found a number of bugs around:

• Domains with TLDs that are not part of the proper set of TLDs
• URIs with schemes that Java doesn't know about.
• IN_SUBNET takes multiple CIDRs, but only evaluates the first one.

Generally calling validate on these methods can be unsafe because they do not handle null arguments correctly.

Issue Links

• links to: GitHub Pull Request #402