Uploaded image for project: 'Metron'
  1. Metron
  2. METRON-1033

Profiler example uses incorrect units for expires

    Details

    • Type: Bug
    • Status: Done
    • Priority: Trivial
    • Resolution: Done
    • Affects Version/s: 0.4.0
    • Fix Version/s: 0.4.1
    • Labels:

      Description

      The profiler documentation states that expires is in ms, but examples show (correctly) days.

        Issue Links

          Activity

          Hide
          nickwallen Nick Allen added a comment -

          The `expires` field is expected to be in days (not milliseconds).

          Show
          nickwallen Nick Allen added a comment - The `expires` field is expected to be in days (not milliseconds).
          Hide
          simonellistonball Simon Elliston Ball added a comment -

          Good point! fixed the issue after digging in the code.

          Show
          simonellistonball Simon Elliston Ball added a comment - Good point! fixed the issue after digging in the code.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user simonellistonball opened a pull request:

          https://github.com/apache/metron/pull/648

          METRON-1033 Corrected profiler docs units on expires field

          Minor change to update profiler docs

            1. Contributor Comments
              [Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.]
            1. Pull Request Checklist

          Thank you for submitting a contribution to Apache Metron.
          Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
          Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.

          In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

              1. For all changes:
              1. For documentation related changes:
          • [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/simonellistonball/incubator-metron METRON-1033

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/metron/pull/648.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #648


          commit 880e10cfc31f49cb11a3f5639c2c0a217743c044
          Author: Simon Elliston Ball <simon@simonellistonball.com>
          Date: 2017-07-12T16:30:25Z

          Corrected profiler docs units on expires field


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/648 METRON-1033 Corrected profiler docs units on expires field Minor change to update profiler docs Contributor Comments [Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.] Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines] ( https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235 ) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines] ( https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview ) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: For all changes: [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira] ( https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel ). [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. [x] Has your PR been rebased against the latest commit within the target branch (typically master)? For documentation related changes: [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/incubator-metron METRON-1033 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/648.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #648 commit 880e10cfc31f49cb11a3f5639c2c0a217743c044 Author: Simon Elliston Ball <simon@simonellistonball.com> Date: 2017-07-12T16:30:25Z Corrected profiler docs units on expires field
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nickwallen commented on the issue:

          https://github.com/apache/metron/pull/648

          +1 Thanks for the fix, Simon

          Show
          githubbot ASF GitHub Bot added a comment - Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/648 +1 Thanks for the fix, Simon
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/metron/pull/648

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/648

            People

            • Assignee:
              simonellistonball Simon Elliston Ball
              Reporter:
              simonellistonball Simon Elliston Ball
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development