Uploaded image for project: 'Apache MetaModel'
  1. Apache MetaModel
  2. METAMODEL-1158

[membrane] New datasources are validated after creation, offering the worst of both validation modes.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      When I create a new datasource using the membrane API, it seems that the datasource is validated/tried after creation. It produces an error, but ends up having created the datasource regardless.

      As a user I would prefer one of the two options:
      1) fail fast: Validate the datasource before saving it.
      2) fault tolerance: Let me create a datasource that may not work right now, but maybe will work later (ie. maybe a specific file or URL or credentials will be corrected soon).

      To allow these two modes, I think we simply need to parameterize the call with a validation mode parameter.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kaspersorensen opened a pull request:

          https://github.com/apache/metamodel-membrane/pull/9

          METAMODEL-1158: Added handling for data sources that don't validate

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/metamodel-membrane METAMODEL-1158-validation-fix

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/metamodel-membrane/pull/9.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #9


          commit 364686d8f8ded7961789b163a6943e227f262830
          Author: Kasper Sørensen <i.am.kasper.sorensen@gmail.com>
          Date: 2017-08-24T05:39:31Z

          METAMODEL-1158: Added handling for data sources that don't validate


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kaspersorensen opened a pull request: https://github.com/apache/metamodel-membrane/pull/9 METAMODEL-1158 : Added handling for data sources that don't validate You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/metamodel-membrane METAMODEL-1158 -validation-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metamodel-membrane/pull/9.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9 commit 364686d8f8ded7961789b163a6943e227f262830 Author: Kasper Sørensen <i.am.kasper.sorensen@gmail.com> Date: 2017-08-24T05:39:31Z METAMODEL-1158 : Added handling for data sources that don't validate
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/metamodel-membrane/pull/9

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/metamodel-membrane/pull/9

            People

            • Assignee:
              Unassigned
              Reporter:
              kaspersor Kasper Sørensen
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development