[MESOS-9948] master::Slave::hasExecutor occupies 37% of a 150 second perf sample.

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.4, 1.6.3, 1.7.3, 1.8.2, 1.9.1, 1.10.0
• Component/s: master
• Labels: foundations performance
• Target Version/s: 1.5.4, 1.6.3, 1.7.3, 1.8.2, 1.9.1
• Sprint: Foundations: RI-18 55
• Story Points: 3
• Assignee: Benjamin Bannier
• Reporter: Benjamin Mahler
• Created: 21/Aug/19 16:37
• Updated: 01/Nov/19 12:41
• Resolved: 23/Sep/19 12:41

Description

If you drop the attached perf stacks into flamescope, you can see that mesos::internal::master::Slave::hasExecutor occupies 37% of the overall samples!

This function does 3 hashmap lookups, 1 can be eliminated for a quick win. However, the larger improvement here will come from eliminating many of the calls to this function.

This was reported by carlone.

Issue Links

• relates to: MESOS-10000 Consider removing 'hashmap::get'