[MESOS-9743] Argument forwaring in CMake build result in glog 0.4.0 build as shared library

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.8.0
• Component/s: cmake
• Labels: build mesosphere triaged

Environment

macOS 10.14.4, clang 8.0.0, Ninja build system

• Story Points: 1
• Assignee: Unassigned
• Reporter: Jan Schlicht
• Created: 25/Apr/19 07:54
• Updated: 21/Nov/20 01:27

Description

GLog versions >= 0.3.5 introduces a BUILD_SHARED_LIBS CMake option. The CMake configuration of Mesos also has such an option. Because these options are forwarded to third-party packages, GLog will be build as a shared library if Mesos is build with BUILD_SHARED_LIBS=OFF. This is not intended, as in that case the GLog shared library is not copied over, resulting in Mesos binaries failing to start.

$ src/mesos-tests 
dyld: Library not loaded: @rpath/libglog.0.dylib
  Referenced from: /Users/jan/Documents/mesos/build/src/mesos-tests
  Reason: image not found
[1]    75207 abort      src/mesos-tests