[MESOS-9544] SLRP does not clean up destroyed persistent volumes.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.7.0, 1.7.1
• Fix Version/s: 1.7.2, 1.8.0
• Component/s: storage
• Labels: mesosphere mesosphere-dss-beta storage
• Target Version/s: 1.7.2, 1.8.0
• Epic Link: Resource Provider and CSI Tech Debt
• Sprint: Storage R10 Sprint 39
• Story Points: 5
• Assignee: Chun-Hung Hsiao
• Reporter: Chun-Hung Hsiao
• Shepherd: Benjamin Bannier
• Created: 31/Jan/19 02:29
• Updated: 13/Feb/19 03:57
• Resolved: 13/Feb/19 03:57

Description

When a persistent volume created on a ROOT disk is destroyed, the agent will clean up its data: https://github.com/apache/mesos/blob/f44535bca811720fc272c9abad2bc78652d61fe3/src/slave/slave.cpp#L4397
However, this is not the case for PVs on SLRP disks. The agent relies on the SLRP to do the cleanup:
https://github.com/apache/mesos/blob/f44535bca811720fc272c9abad2bc78652d61fe3/src/slave/slave.cpp#L4472
But SLRP simply updates its metadata and do nothing:
https://github.com/apache/mesos/blob/f44535bca811720fc272c9abad2bc78652d61fe3/src/resource_provider/storage/provider.cpp#L2805

This would lead to data leakage if the framework does not call `CREATE_DISK` but just unreserve it.

Issue Links

• blocks: MESOS-9565 Unit tests for creating and destroying persistent volumes in SLRP.