Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-9544

SLRP does not clean up destroyed persistent volumes.

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      When a persistent volume created on a ROOT disk is destroyed, the agent will clean up its data: https://github.com/apache/mesos/blob/f44535bca811720fc272c9abad2bc78652d61fe3/src/slave/slave.cpp#L4397
      However, this is not the case for PVs on SLRP disks. The agent relies on the SLRP to do the cleanup:
      https://github.com/apache/mesos/blob/f44535bca811720fc272c9abad2bc78652d61fe3/src/slave/slave.cpp#L4472
      But SLRP simply updates its metadata and do nothing:
      https://github.com/apache/mesos/blob/f44535bca811720fc272c9abad2bc78652d61fe3/src/resource_provider/storage/provider.cpp#L2805

      This would lead to data leakage if the framework does not call `CREATE_DISK` but just unreserve it.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            chhsia0 Chun-Hung Hsiao
            chhsia0 Chun-Hung Hsiao
            Benjamin Bannier Benjamin Bannier
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Agile

                Completed Sprint:
                Storage R10 Sprint 39 ended 13/Feb/19
                View on Board

                Slack

                  Issue deployment