[MESOS-9340] Log all socket errors in libprocess.

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.2, 1.7.1, 1.8.0
• Component/s: libprocess
• Target Version/s: 1.5.2, 1.6.2, 1.7.1
• Assignee: Benjamin Mahler
• Reporter: Benjamin Mahler
• Created: 21/Oct/18 23:43
• Updated: 22/Oct/19 00:32
• Resolved: 25/Oct/18 00:35

Description

To aid debugging, we need to shore up our logging to ensure that all socket errors in the embedded http server are logged at the warning level and include IP address information of the peer. Looks like we have the following:

(1) recv error: VLOG(1) w/ peer and nothing
(2) send error: nothing
(3) shutdown error: LOG(INFO) sometimes with our own address (weird)
(4) connect error: LOG(WARNING) with destination address
(5) accept error: LOG(WARNING)
(6) listen error: LOG(FATAL)

Issue Links

• is related to: MESOS-10017 Log all reverse DNS lookup failures in 'legacy' TLS (SSL) hostname validation scheme.
• is related to: MESOS-9773 Log the peer address during SSL handshake failure.
• supercedes: MESOS-1661 socket errors should show IP address