Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-9056

mesos-style.py messaging is poor

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7.0, 1.8.0
    • Fix Version/s: 1.8.0
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Sprint:
      Mesosphere RI-6 Sprint 2018-30
    • Story Points:
      1

      Description

      After running into all sorts of issues connected to the -c option, at some point I tried the -k option and got the following output;

      ➜ apache-mesos (MESOS-9056) ✔ python3 support/apply-reviews.py -k -r 66683
      2018-10-05 12:14:19 URL:https://reviews.apache.org/r/66683/diff/raw/ [1863/1863] -> "66683.patch" [1]
      No C++ files to lint
      No JavaScript files to lint
      Checking 2 Python files
      Total errors found: 0
      [MESOS-9056 5f8f48b7a] Updated address field of new CLI config to accept URLs.
      Author: Armand Grillet <agrillet@mesosphere.io>
      2 files changed, 12 insertions(+), 2 deletions(-)
      

      It appears that the messaging here is worth reconsidering;

      • "No C++ files to lint", "No JavaScript files to lint", "Total errors found: 0" seems to have little value for the normal user - how about we make that a user activated verbose output?

        Attachments

          Activity

            People

            • Assignee:
              ArmandGrillet Armand Grillet
              Reporter:
              tillt Till Toenshoff
              Shepherd:
              Till Toenshoff
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: