[MESOS-8875] `leveldb::PosixEnv::DeleteFile()` can segfault.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.0
• Fix Version/s: 1.7.0
• Labels: flaky-test mesosphere storage
• Epic Link: Resource Provider and CSI Tech Debt
• Assignee: Benjamin Bannier
• Reporter: Chun-Hung Hsiao
• Shepherd: Chun-Hung Hsiao
• Created: 03/May/18 00:55
• Updated: 15/Jun/18 13:47
• Resolved: 15/Jun/18 13:47

Description

Patch https://reviews.apache.org/r/66310/ instantiate a LevelDBStorage for the registrar of the agent-side resource provider manager. This change seems to introduce flaky segfaults to various tests, including MasterAPITest.Subscribe, MasterTest.UnacknowledgedTerminalTask, ReconciliationTest.ImplicitTerminalTask and MasterAuthorizerTest/1.FilterStateEndpoint. The segfault usually happens after successfully attached the virtual path of a launched default executor:

I0502 21:47:31.329772  4511 paths.cpp:745] Creating sandbox '/tmp/ContentType_MasterAPITest_Subscribe_1_HzYh4s/slaves/82b400f9-82ed-4fdc-9f34-8c652dc502a8-S0/frameworks/82b400f9-82ed-4fdc-9f34-8c652dc502a8-0000/executors/default/runs/398c5e60-5141-43f0-9856-98c05d501b33' for user 'root'
I0502 21:47:31.330245  4511 slave.cpp:8964] Launching executor 'default' of framework 82b400f9-82ed-4fdc-9f34-8c652dc502a8-0000 with resources [] in work directory '/tmp/ContentType_MasterAPITest_Subscribe_1_HzYh4s/slaves/82b400f9-82ed-4fdc-9f34-8c652dc502a8-S0/frameworks/82b400f9-82ed-4fdc-9f34-8c652dc502a8-0000/executors/default/runs/398c5e60-5141-43f0-9856-98c05d501b33'
I0502 21:47:31.330423  4511 slave.cpp:3044] Queued task '7e968920-a780-4265-9e4b-e56e091ff27e' for executor 'default' of framework 82b400f9-82ed-4fdc-9f34-8c652dc502a8-0000
I0502 21:47:31.330549  4511 slave.cpp:3523] Launching container 398c5e60-5141-43f0-9856-98c05d501b33 for executor 'default' of framework 82b400f9-82ed-4fdc-9f34-8c652dc502a8-0000
I0502 21:47:31.330747  4515 slave.cpp:1008] Successfully attached '/tmp/ContentType_MasterAPITest_Subscribe_1_HzYh4s/slaves/82b400f9-82ed-4fdc-9f34-8c652dc502a8-S0/frameworks/82b400f9-82ed-4fdc-9f34-8c652dc502a8-0000/executors/default/runs/398c5e60-5141-43f0-9856-98c05d501b33' to virtual path '/tmp/ContentType_MasterAPITest_Subscribe_1_HzYh4s/slaves/82b400f9-82ed-4fdc-9f34-8c652dc502a8-S0/frameworks/82b400f9-82ed-4fdc-9f34-8c652dc502a8-0000/executors/default/runs/latest'
I0502 21:47:31.330814  4515 slave.cpp:1008] Successfully attached '/tmp/ContentType_MasterAPITest_Subscribe_1_HzYh4s/slaves/82b400f9-82ed-4fdc-9f34-8c652dc502a8-S0/frameworks/82b400f9-82ed-4fdc-9f34-8c652dc502a8-0000/executors/default/runs/398c5e60-5141-43f0-9856-98c05d501b33' to virtual path '/frameworks/82b400f9-82ed-4fdc-9f34-8c652dc502a8-0000/executors/default/runs/latest'
I0502 21:47:31.331126  4511 slave.cpp:1008] Successfully attached '/tmp/ContentType_MasterAPITest_Subscribe_1_HzYh4s/slaves/82b400f9-82ed-4fdc-9f34-8c652dc502a8-S0/frameworks/82b400f9-82ed-4fdc-9f34-8c652dc502a8-0000/executors/default/runs/398c5e60-5141-43f0-9856-98c05d501b33' to virtual path '/tmp/ContentType_MasterAPITest_Subscribe_1_HzYh4s/slaves/82b400f9-82ed-4fdc-9f34-8c652dc502a8-S0/frameworks/82b400f9-82ed-4fdc-9f34-8c652dc502a8-0000/executors/default/runs/398c5e60-5141-43f0-9856-98c05d501b33'
*** Aborted at 1525297651 (unix time) try "date -d @1525297651" if you are using GNU date ***
I0502 21:47:31.331786  4515 executor.cpp:192] Version: 1.6.0
W0502 21:47:31.331804  4515 process.cpp:2824] Attempted to spawn already running process version@172.16.10.128:37498
I0502 21:47:31.332619  4515 executor.cpp:414] Connected with the agent
I0502 21:47:31.332749  4515 executor.cpp:311] Sending SUBSCRIBE call to http://172.16.10.128:37498/slave(945)/api/v1/executor
PC: @     0x7f9239ecd0ed __GI_getenv
*** SIGSEGV (@0x171) received by PID 13317 (TID 0x7f922de28700) from PID 369; stack trace: ***
    @     0x7f922cca2155 (unknown)
    @     0x7f922cca6e41 (unknown)
    @     0x7f922cc9a678 (unknown)
    @     0x7f923ae935e0 (unknown)
    @     0x7f9239ecd0ed __GI_getenv
    @     0x7f9239ec4d61 __dcigettext
    @     0x7f9239f1ba9e __GI___strerror_r
    @     0x7f9239f1b9df strerror
    @     0x7f923dde4e23 leveldb::(anonymous namespace)::IOError()
    @     0x7f923dde5832 leveldb::(anonymous namespace)::PosixEnv::DeleteFile()
    @     0x7f923dde1628 leveldb::BuildTable()
    @     0x7f923ddbd5b4 leveldb::DBImpl::WriteLevel0Table()
    @     0x7f923ddbf6c8 leveldb::DBImpl::CompactMemTable()
    @     0x7f923ddc0756 leveldb::DBImpl::BackgroundCompaction()
    @     0x7f923ddc1172 leveldb::DBImpl::BackgroundCall()
    @     0x7f923dde55cb leveldb::(anonymous namespace)::PosixEnv::BGThreadWrapper()
    @     0x7f923ae8be25 start_thread
    @     0x7f9239f8d34d __clone

leveldb maintains a global singleton of PosixEnv, whose DeleteFile() callback sometimes fails to unlink a ldb file, and it uses strerror() to report the error, which seems to call getenv, and this increase the likelihood of some setenv-getenv race described in https://issues.apache.org/jira/browse/MESOS-2407.

It is worth investigating why DeleteFile() fails.

Issue Links

• is broken by: MESOS-3475 TestContainerizer should not modify global environment variables.
• is related to: MESOS-2407 libprocess segfaults when using GLOG_v=2