[MESOS-8856] UNIMPLEMENTED macro in stout could conflict with protobuf

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: stout
• Assignee: Unassigned
• Reporter: Zhitao Li
• Created: 01/May/18 21:18
• Updated: 01/May/18 21:19

Description

When I tried to use UNIMPLEMENTED macro defined in 3rdparty/stout/include/stout/unimplemented.hpp, it conflicted with an `UNIMPLEMENTED` macro in

{build_dir}

/3rdparty/protobuf-3.5.0/src/google/protobuf/stubs/status.h

Although the latter is an enum like this:

namespace google {
namespace protobuf {
namespace util {
namespace error {
// These values must match error codes defined in google/rpc/code.proto.
enum Code {
  OK = 0,
...
  UNIMPLEMENTED = 12,
...
};
}  // namespace error

Preprocessor would transform the enum into incorrect macro.

cc + chhsia0