Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-8786

CgroupIsolatorProcess accesses subsystem processes directly.

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0, 1.2.0, 1.3.0, 1.4.0, 1.5.0, 1.6.0
    • Fix Version/s: 1.4.2, 1.5.1, 1.6.1, 1.7.0
    • Component/s: containerization
    • Labels:
      None
    • Target Version/s:
    • Sprint:
      Mesosphere Sprint 78, Mesosphere Sprint 79, Mesosphere Sprint 2018-20
    • Story Points:
      5

      Description

      The CgroupsIsolatorProcess interacts with the different cgroups subsystems via Processes dealing with a dedicated subsystem each. Each Process is held by CgroupsIsolatorProcess directly and e.g., no intermediate wrapper class is involved performing dispatch to an underlying process.

      Since no wrapper around these Subsystem processes is used, a user needs to make sure to only dispatch to the process himself, he should e.g., never directly invoke functions on the Process or else inconsistencies or races can arise inside the Subsystem process; if e.g., a Subsystem dispatches to itself, CgroupsIsolatorProcess might concurrently invoke Subsystem functions.
       
      CgroupsIsolatorProcess does not always dispatch to these process, but invokes them directly. We should fix this by either introducing wrappers around the Subsystem wrappers, or by explicitly fixing CgroupsIsolatorProcess to always use dispatch to interact with its subsystems. While the first approach seems cleaner and more future-proof, the latter might be less effort now.

        Attachments

          Activity

            People

            • Assignee:
              bbannier Benjamin Bannier
              Reporter:
              bbannier Benjamin Bannier
              Shepherd:
              Gilbert Song
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: