Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-8764

Delete WindowsSocketError and reconcile with SocketError and WindowsError

    XMLWordPrintableJSON

Details

    • Task
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      It turns out that there is no actual difference between WSAGetLastError and GetLastError, the former is an alias for the latter (also see here. As such, there is no difference between WindowsError and WindowsSocketError.

      So we should delete the notion of a separate WindowsSocketError class, and reconcile SocketError. Then WindowsErrorBase can disappear, leaving us with just WindowsError.

      Moreover, with the use of CRT APIs pretty much gone, we probably no longer need ErrnoError defined in the Windows code either, so we could find a way to make WindowsError and ErrnoError the transparent platform-defaults (though is not necessarily a good idea).

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              andschwa Andrew Schwartzmeyer
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: