[MESOS-8662] Consider introducing a clang-tidy check to catch ambiguous use of FUTURE_DISPATH

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: libprocess
• Labels: clang-tidy
• Assignee: Unassigned
• Reporter: Benjamin Bannier
• Created: 12/Mar/18 17:02
• Updated: 12/Mar/18 17:02

Description

Currently FUTURE_DISPATCH cannot distinguish between two dispatched functions with identical signatures, see MESOS-5886.

As solving this issue on the implementation side seems tricky, we should investigate whether we can more quickly come up with a clang-tidy check to catch instances of such ambiguity. The general workflow seems to be

• For every use of FUTURE_DISPATCH
  • get type of dispatched to actor
  • get signature of dispatched to function
  • iterate over methods of actor checking for possible ambiguities with the dispatched to function's signature
    • diagnose ambiguity

Issue Links

• relates to: MESOS-5886 FUTURE_DISPATCH may react on irrelevant dispatch.