[MESOS-8640] Validate `DockerInfo` exists when container's type is `DOCKER`

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: containerization
• Target Version/s: 1.6.0
• Sprint: Mesosphere Sprint 76
• Story Points: 2
• Assignee: Qian Zhang
• Reporter: Qian Zhang
• Shepherd: Gilbert Song
• Created: 06/Mar/18 02:04
• Updated: 13/Mar/18 05:47
• Resolved: 13/Mar/18 05:47

Description

Currently when framework launches a task whose ContainerInfo's type is DOCKER (i.e., Docker containerizer will be used to launch the container), we do not validate if the `DockerInfo` exists in the ContainerInfo, so such task will be sent from master to agent, and will eventually fail due to pulling image with empty name.

Failed to launch container: Failed to run 'docker -H unix:///var/run/docker.sock pull :latest': exited with status 1; stderr='invalid reference format'

Actually we have a validation in this code, but it is too late (i.e., when Docker executor tries to create the Docker container), we should do the validation much earlier, e.g., in master.

Issue Links

• is depended upon by: MESOS-8497 Docker parameter `name` does not work with Docker Containerizer.