[MESOS-8576] Improve discard handling of 'Docker::inspect()'

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Done
• Affects Version/s: 1.5.0
• Fix Version/s: 1.4.2, 1.5.1, 1.6.0
• Component/s: containerization, docker
• Labels: mesosphere
• Epic Link: Docker Improvements
• Sprint: Mesosphere Sprint 75
• Story Points: 3
• Assignee: Greg Mann
• Reporter: Greg Mann
• Shepherd: Michael Park
• Created: 13/Feb/18 08:15
• Updated: 22/Mar/19 16:41
• Resolved: 01/Mar/18 00:19

Description

In the call path of Docker::inspect(), each continuation currently checks if promise->future().hasDiscard(), where the promise is associated with the output of the docker inspect call. However, if the call to docker inspect becomes hung indefinitely, then continuations are never invoked, and a subsequent discard of the returned Future will have no effect. We should add proper onDiscard handling to that Future so that appropriate cleanup is performed in such cases.

Issue Links

• duplicates: MESOS-8575 Improve discard handling for 'Docker::stop' and 'Docker::pull'.