[MESOS-8482] Signed/Unsigned comparisons in tests

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: test
• Labels: mesosphere newbie tech-debt
• Sprint: Mesosphere Sprint 73
• Story Points: 1
• Assignee: Benno Evers
• Reporter: Benno Evers
• Shepherd: Benjamin Bannier
• Created: 24/Jan/18 12:41
• Updated: 25/Jan/18 14:54
• Resolved: 25/Jan/18 14:54

Description

Many tests in mesos currently have comparisons between signed and unsigned integers, eg

    ASSERT_EQ(4, v1Response->read_file().size());

or comparisons between values of different enums, e.g. TaskState and v1::TaskState:

  ASSERT_EQ(TASK_STARTING, startingUpdate->status().state());

Usually, the compiler would catch these and emit a warning, but these are currently silenced because gtest headers are included using the -isystem command line flag.

Issue Links

• blocks: MESOS-7699 "stdlib.h: No such file or directory" when building with GCC 6 (Debian stable freshly released)