Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-7801

Retry logic for unsuccessful `docker rm` during agent recovery

    Details

    • Type: Improvement
    • Status: Reviewable
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: docker
    • Labels:
      None
    • Sprint:
      Mesosphere Sprint 59
    • Story Points:
      3

      Description

      In MESOS-7777 we skip the failure when `docker rm` fails due to mount leakage during agent recovery. In order not to leave residual docker containers in the docker daemon, we could do a best-effort `docker rm` retry with an exponential backoff since we cannot control when the leakage would be terminated.

        Issue Links

          Activity

          Show
          chhsia0 Chun-Hung Hsiao added a comment - Patches for review: https://reviews.apache.org/r/60887/ https://reviews.apache.org/r/60846/ + Gilbert Song
          Hide
          xds2000 Deshi Xiao added a comment -

          please update it asap.

          Show
          xds2000 Deshi Xiao added a comment - please update it asap.
          Hide
          xds2000 Deshi Xiao added a comment -

          Jie Yu does this patch can summited?

          Show
          xds2000 Deshi Xiao added a comment - Jie Yu does this patch can summited?
          Hide
          chhsia0 Chun-Hung Hsiao added a comment -

          Hi Deshi Xiao. This patch is an optimization for MESOS-7777, which has been landed a while ago. I'd like to see this patch landed but since it is just an optimization, it might not receive as high priority as other pending issues. I was wondering if you encounter any problem that cannot be resolved by the patch for MESOS-7777. Could you provide more information to help us understand the severity? Thanks!

          Show
          chhsia0 Chun-Hung Hsiao added a comment - Hi Deshi Xiao . This patch is an optimization for MESOS-7777 , which has been landed a while ago. I'd like to see this patch landed but since it is just an optimization, it might not receive as high priority as other pending issues. I was wondering if you encounter any problem that cannot be resolved by the patch for MESOS-7777 . Could you provide more information to help us understand the severity? Thanks!
          Hide
          xds2000 Deshi Xiao added a comment -

          MESOS-7777 already resolve my case, i have not provide another issue right now, i just curious that why the optimization patch is always pending? it let me confuse abt the general workflow.

          Show
          xds2000 Deshi Xiao added a comment - MESOS-7777 already resolve my case, i have not provide another issue right now, i just curious that why the optimization patch is always pending? it let me confuse abt the general workflow.
          Hide
          gilbert Gilbert Song added a comment -

          Deshi Xiao, sorry for the delay on this optimization change. Jie and I are under heavy workloads and did not get a chance onto this issue. We will try to prioritize this from our side. Any comments from you on those two patches will be absolutely welcome.

          Show
          gilbert Gilbert Song added a comment - Deshi Xiao , sorry for the delay on this optimization change. Jie and I are under heavy workloads and did not get a chance onto this issue. We will try to prioritize this from our side. Any comments from you on those two patches will be absolutely welcome.
          Hide
          xds2000 Deshi Xiao added a comment -

          Gilbert Song thanks for your clarify. i will join it asap.

          Show
          xds2000 Deshi Xiao added a comment - Gilbert Song thanks for your clarify. i will join it asap.

            People

            • Assignee:
              chhsia0 Chun-Hung Hsiao
              Reporter:
              chhsia0 Chun-Hung Hsiao
              Shepherd:
              Jie Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development

                  Agile