Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-7772

Copy-n-paste error in slave/main.cpp

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Blocker
    • Resolution: Fixed
    • 1.4.0
    • 1.4.0
    • agent

    Description

      Coverity diagnosed a copy-n-paste error in slave/main.cpp (https://scan5.coverity.com/reports.htm#v10074/p10429/fileInstanceId=120155401&defectInstanceId=33592186&mergedDefectId=1414687+1+Comment),

      323  } else if (flags.ip6.isSome()) {
      CID 1414687 (#1 of 1): Copy-paste error (COPY_PASTE_ERROR)
      copy_paste_error: ip in flags.ip looks like a copy-paste error.
         	Should it say ip6 instead?
      324    os::setenv("LIBPROCESS_IP6", flags.ip.get());
      325  }
      

      We check the incorrect IP for some value here (check on ip6, but use of ip), and it seems extremely likely we intended to use flags.ip6.

      Attachments

        Activity

          People

            avinash.mesos Avinash Sridharan
            bbannier Benjamin Bannier
            Benjamin Hindman Benjamin Hindman
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: