[MESOS-7762] net::IP::Network not building on Windows

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: stout
• Labels: mesosphere windows

Environment

Windows 10 and Linux (with port-mapping network isolator)

• Sprint: Mesosphere Sprint 58
• Story Points: 1
• Assignee: Avinash Sridharan
• Reporter: Andrew Schwartzmeyer
• Shepherd: Kapil Arya
• Created: 05/Jul/17 23:11
• Updated: 06/Jul/17 17:03
• Resolved: 06/Jul/17 17:03

Description

Building master (well, 2c1be9ced) is currently broken on Windows. Repro:

git checkout 2c1be9ced 
mkdir build
cd build 
cmake .. -DENABLE_LIBEVENT=1 -DHAS_AUTHENTICATION=0 -G "Visual Studio 15 2017 Win64" -T "host=x64"
cmake --build . --target stout-tests

(Build instructions here: https://github.com/apache/mesos/blob/master/docs/windows.md)

Get a bunch of compilation errors:

"C:\Users\andschwa\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
(ClCompile target) ->
  C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\include\stout/windows/ip.hpp(31): error C2065: 'IPNetwork': undeclared identifier (compiling source file C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\tests\ip_tests.cpp) [C:\Users\ands
chwa\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj]
  C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\include\stout/windows/ip.hpp(31): error C2923: 'Result': 'IPNetwork' is not a valid template type argument for parameter 'T' (compiling source file C:\Users\andschwa\src\mesos-copy2\3rdpar
ty\stout\tests\ip_tests.cpp) [C:\Users\andschwa\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj]
  C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\include\stout/windows/ip.hpp(31): error C2653: 'IPNetwork': is not a class or namespace name (compiling source file C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\tests\ip_tests.cpp) [C:
\Users\andschwa\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj]
  C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\include\stout/windows/ip.hpp(34): error C2079: 'net::fromLinkDevice' uses undefined class 'Result' (compiling source file C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\tests\ip_tests.cp
p) [C:\Users\andschwa\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj]
  C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\include\stout/windows/ip.hpp(41): error C2440: 'return': cannot convert from 'Error' to 'Result' (compiling source file C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\tests\ip_tests.cpp)
 [C:\Users\andschwa\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj]
  C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\include\stout/windows/ip.hpp(49): error C2440: 'return': cannot convert from 'WindowsError' to 'Result' (compiling source file C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\tests\ip_tes
ts.cpp) [C:\Users\andschwa\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj]
  C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\include\stout/windows/ip.hpp(58): error C2440: 'return': cannot convert from 'WindowsError' to 'Result' (compiling source file C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\tests\ip_tes
ts.cpp) [C:\Users\andschwa\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj]
  C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\include\stout/windows/ip.hpp(70): error C2065: 'IPNetwork': undeclared identifier (compiling source file C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\tests\ip_tests.cpp) [C:\Users\ands
chwa\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj]
  C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\include\stout/windows/ip.hpp(70): error C2923: 'Try': 'IPNetwork' is not a valid template type argument for parameter 'T' (compiling source file C:\Users\andschwa\src\mesos-copy2\3rdparty\
stout\tests\ip_tests.cpp) [C:\Users\andschwa\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj]
  C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\include\stout/windows/ip.hpp(70): error C2653: 'IPNetwork': is not a class or namespace name (compiling source file C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\tests\ip_tests.cpp) [C:
\Users\andschwa\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj]
  C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\include\stout/windows/ip.hpp(70): error C3861: 'create': identifier not found (compiling source file C:\Users\andschwa\src\mesos-copy2\3rdparty\stout\tests\ip_tests.cpp) [C:\Users\andschwa
\src\mesos-copy2\build\3rdparty\stout\tests\stout-tests.vcxproj]
...