[MESOS-7658] apply-reviews.py fails with Unicode characters

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Fix Version/s: 1.7.0
• Labels: reviewboard
• Epic Link: Use Python 3 in our codebase
• Assignee: Armand Grillet
• Reporter: Andrew Schwartzmeyer
• Shepherd: Joseph Wu
• Created: 13/Jun/17 22:33
• Updated: 25/May/18 08:45
• Resolved: 25/May/18 08:45

Description

This prevents commits from being applied if the name or message contains non-ASCII characters, and so can break the Windows ReviewBot.

> git checkout b2801f0012535e29609f603b4324a9ca693f70cb~
> python .\support\apply-reviews.py -r 59874
Traceback (most recent call last):
  File ".\support\apply-reviews.py", line 381, in <module>
    reviewboard()
  File ".\support\apply-reviews.py", line 360, in reviewboard
    apply_review()
  File ".\support\apply-reviews.py", line 126, in apply_review
    commit_patch()
  File ".\support\apply-reviews.py", line 225, in commit_patch
    shell(cmd, options['dry_run'])
  File ".\support\apply-reviews.py", line 111, in shell
    error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
  File "C:\Python27\lib\subprocess.py", line 168, in call
    return Popen(*popenargs, **kwargs).wait()
  File "C:\Python27\lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\Python27\lib\subprocess.py", line 610, in _execute_child
    args = '{} /c "{}"'.format (comspec, args)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 25: ordinal not in range(128)
~\src\mesos-copy2 |-/

Issue Links

• is related to: MESOS-8770 Use Python3 for Mesos support scripts
• links to: GitHub Pull Request #284