[MESOS-7581] Specifying an unbundled dependency can cause build to pick up wrong Boost version

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.3, 1.2.2, 1.3.1
• Fix Version/s: 1.1.3, 1.2.2, 1.3.1, 1.4.0
• Component/s: build
• Labels: autotools mesosphere
• Target Version/s: 1.1.3, 1.2.2, 1.3.1
• Sprint: Mesosphere Sprint 57
• Story Points: 1
• Assignee: Benjamin Bannier
• Reporter: Benjamin Bannier
• Shepherd: Till Toenshoff
• Created: 29/May/17 08:34
• Updated: 29/Apr/19 09:26
• Resolved: 08/Jun/17 19:08

Description

Specifying an unbundled dependency can cause the build to pick up a wrong Boost version. Assuming we have e.g., both protobuf and Boost installed in PREFIX, configuring with --with-protobuf=PREFIX causes the build to pick up the Boost version from PREFIX instead of using the bundled one.

This appears to be due to how we specify Boost include paths. Boost paths are added with -isystem to suppress warnings; the protobuf include path, on the other hand, would be added with -I. GCC and for compatibility clang first search all paths specified with -I left-to-right before looking at paths given with -isystem, see the GCC documenation.

Issue Links

• blocks: MESOS-7642 Consider unbundling protobuf dependency
• breaks: MESOS-7699 "stdlib.h: No such file or directory" when building with GCC 6 (Debian stable freshly released)
• is duplicated by: MESOS-7717 Compile Problem on coreos build in libprocess
• is required by: MESOS-7717 Compile Problem on coreos build in libprocess