Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-7287

Fix post-reviews.py to find `rbt.cmd` on Windows

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 1.3.0
    • None
    • Windows 10 with RBTools 0.7.9 alpha 0 (dev)

    Description

      The script cannot find `rbt` since the command on Windows is `rbt.cmd` and `CreateProcess` (used by Python's Popen implementation) will not search through suffixes (PowerShell, however, does do this, so don't be confused when PowerShell can find `rbt`). So the script needs to use `rbt.cmd` when on Windows.

      Attachments

        Activity

          People

            andschwa Andrew Schwartzmeyer
            andschwa Andrew Schwartzmeyer
            Joseph Wu Joseph Wu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: