Details
-
Task
-
Status: Accepted
-
Major
-
Resolution: Unresolved
-
None
-
None
Description
As part of this work, we'll need to ensure hierarchical role metrics are correctly accounting in a hierarchical way, where appropriate.
Also note that hierarchical roles are already showing up in metric keys, since much of the metrics code just appends the role string directly:
"allocator/mesos/offer_filters/roles/*/active": 88, "allocator/mesos/offer_filters/roles/monitoring-role/active": 0, "allocator/mesos/offer_filters/roles/slave_public/active": 171, "allocator/mesos/offer_filters/roles/spark-dispatcher/active": 288,
This means the hierarchical role slashes are exposed directly in the metric key, which makes parsing more difficult. We should consider encoding the role, much like we did with the framework names: https://github.com/apache/mesos/commit/45fa0593790632a5c1231b350921281dded1c1aa#diff-544616f159a85e652cd4744ef4729921R561