[MESOS-6919] Libprocess reinit code leaks SSL server socket FD

• Type: Bug
• Status: Accepted
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.2.0
• Component/s: libprocess
• Labels: foundations libprocess mesosphere ssl
• Sprint: Mesosphere Sprint 52, Mesosphere Sprint 53, Mesosphere Sprint 54, Mesosphere Sprint 55
• Story Points: 2
• Assignee: Joseph Wu
• Reporter: Greg Mann
• Created: 13/Jan/17 16:01
• Updated: 06/Feb/19 17:16

Description

After this commit, it was discovered that tests which use process::reinitialize to switch between SSL and non-SSL modes will leak the file descriptor associated with the server socket __s__. This can be reproduced by running the following trivial test in repetition:

diff --git a/src/tests/scheduler_tests.cpp b/src/tests/scheduler_tests.cpp
index 1ff423f..d5fd575 100644
--- a/src/tests/scheduler_tests.cpp
+++ b/src/tests/scheduler_tests.cpp
@@ -1821,6 +1821,12 @@ INSTANTIATE_TEST_CASE_P(
 #endif // USE_SSL_SOCKET


+TEST_P(SchedulerSSLTest, LeakTest)
+{
+  ::sleep(1);
+}
+
+
 // Tests that a scheduler can subscribe, run a task, and then tear itself down.
 TEST_P(SchedulerSSLTest, RunTaskAndTeardown)
 {

Issue Links

• relates to: MESOS-7106 Test ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 segfaults