[MESOS-6829] Mesos fails to compile when using FORTIFY_SOURCE without optimizations

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: build, libprocess, security, stout
• Target Version/s: 1.2.0
• Assignee: Aaron Wood
• Reporter: Aaron Wood
• Shepherd: Michael Park
• Created: 21/Dec/16 21:51
• Updated: 29/Apr/19 09:28
• Resolved: 22/Dec/16 06:07

Description

Fome some versions of gcc/glibc a warning will be produced with FORTIFY_SOURCE is used without optimizations enabled (see here for related information https://sourceware.org/bugzilla/show_bug.cgi?id=13979). This only happens in some environments such as CentOS 7 and Arch Linux with GCC 6.2.

Probably one of the reasons why it didn't get caught earlier by CI:

"This #warning appears to be causing more grief than it is solving; for example, see this autoconf thread that complains that it is breaking configure scripts, and therefore Debian's decision to revert this patch in their build of glibc:

https://lists.gnu.org/archive/html/autoconf/2013-05/msg00003.html
http://anonscm.debian.org/viewvc/pkg-glibc/glibc-package/trunk/debian/patches/any/local-revert-bz13979.diff?revision=5553&view=markup"

https://reviews.apache.org/r/54949/
https://reviews.apache.org/r/54950/
https://reviews.apache.org/r/54951/