[MESOS-6802] SSL socket can lose bytes in the case of EOF

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: libprocess
• Labels: libevent libprocess ssl
• Epic Link: SSL Tech Debt
• Sprint: Mesosphere Sprint 49
• Story Points: 3
• Assignee: Greg Mann
• Reporter: Greg Mann
• Shepherd: Joseph Wu
• Created: 15/Dec/16 17:52
• Updated: 16/Jan/18 17:53
• Resolved: 11/Jan/17 02:49

Description

During recent work on SSL-enabled tests in libprocess (MESOS-5966), we discovered a bug in LibeventSSLSocketImpl, wherein the socket can either fail to receive an EOF, or lose data when an EOF is received.

The LibeventSSLSocketImpl::event_callback(short events) method immediately sets any pending RecvRequest's promise to zero upon receipt of an EOF. However, at the time the promise is set, there may actually be data waiting to be read by libevent. Upon receipt of an EOF, we should attempt to read the socket's bufferevent first to ensure that we aren't losing any data previously received by the socket.

Issue Links

• relates to: MESOS-6799 Scheme/HTTPTest.Endpoints/0 is flaky
• relates to: MESOS-7028 NetSocketTest.EOFBeforeRecv is flaky.