Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-6789

SSL socket's 'shutdown()' method is broken

    XMLWordPrintableJSON

    Details

      Description

      We recently uncovered two issues with the LibeventSSLSocketImpl::shutdown method:

      • The introduction of a shutdown method parameter with this commit means that the implementation's method is no longer overriding the default implementation. In addition to fixing the implementation method's signature, we should add the override specifier to all of our socket implementations' methods to ensure that this doesn't happen in the future.
      • The LibeventSSLSocketImpl::shutdown function does not actually shutdown the SSL socket. The proper function to shutdown an SSL socket is SSL_shutdown, which is called in the implementation's destructor. We should move this into shutdown() so that by the time that method returns, the socket has actually been shutdown.

        Attachments

          Activity

            People

            • Assignee:
              greggomann Greg Mann
              Reporter:
              greggomann Greg Mann
              Shepherd:
              Joseph Wu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: