[MESOS-6789] SSL socket's 'shutdown()' method is broken

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: libprocess
• Labels: encryption libprocess ssl
• Target Version/s: 1.2.0
• Epic Link: SSL Tech Debt
• Sprint: Mesosphere Sprint 49
• Story Points: 2
• Assignee: Greg Mann
• Reporter: Greg Mann
• Shepherd: Joseph Wu
• Created: 14/Dec/16 00:00
• Updated: 01/Sep/17 23:33
• Resolved: 14/Jan/17 00:24

Description

We recently uncovered two issues with the LibeventSSLSocketImpl::shutdown method:

• The introduction of a shutdown method parameter with this commit means that the implementation's method is no longer overriding the default implementation. In addition to fixing the implementation method's signature, we should add the override specifier to all of our socket implementations' methods to ensure that this doesn't happen in the future.
• The LibeventSSLSocketImpl::shutdown function does not actually shutdown the SSL socket. The proper function to shutdown an SSL socket is SSL_shutdown, which is called in the implementation's destructor. We should move this into shutdown() so that by the time that method returns, the socket has actually been shutdown.