[MESOS-6753] Refactor duplicated code for framework registration in master

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: master
• Labels: mesosphere
• Assignee: Unassigned
• Reporter: Neil Conway
• Created: 07/Dec/16 22:41
• Updated: 07/Dec/16 22:43

Description

It would be nice to refactor the code and eliminate some/all of these redundancies:

• Master::activateRecoveredFramework and Master::_failoverFramework duplicate some code.
• Master::_subscribe for PID-based schedulers has a code path that contains code that is very similar to the Master::failoverFramework logic, but is not identical.
• The logic around updateConnection could stand to be cleaned up. e.g., it seems like updateConnection could/should be responsible for linking to the target PID and/or setting up the closed callback (for PID or HTTP schedulers, respectively).

Issue Links

• is related to: MESOS-6419 The 'master/teardown' endpoint should support tearing down 'unregistered_frameworks'.