[MESOS-6730] Reserve operation should validate reserved resource role against resource allocationInfo role

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Epic Link: multi-role frameworks (phase 1)
• Sprint: Mesosphere Sprint 51
• Story Points: 3
• Assignee: Benjamin Bannier
• Reporter: Guangya Liu
• Shepherd: Guangya Liu
• Created: 06/Dec/16 16:19
• Updated: 26/Mar/18 08:08
• Resolved: 16/Feb/17 02:07

Description

When doing dynamic reservation validation, the current logic is make sure the reserved resources role is same as the framework role (see src/master/validation.cpp):

  if (frameworkRole.isSome() && resource.role() != frameworkRole.get()) {
      return Error(
          "A reserve operation was attempted for a resource with role"
          " '" + resource.role() + "', but the framework can only reserve"
          " resources with role '" + frameworkRole.get() + "'");
    }

With multi-role framework, we should validate reserved resource role same as resource allocation role.

Please make sure distinguish dynamic reservation with framework and http endpoint. If dynamic reservation was triggered by a framework, then we need to do such validation. If done by the http endpoint, then no need to validate the roles.

Issue Links

• is blocked by: MESOS-6635 Update allocator to handle multi-role frameworks.