[MESOS-6677] Error in Windows agent's Flags::runtime_dir CLI

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 1.2.0
• Component/s: cli
• Labels: microsoft newbie windows

Environment

Windows 10
Commit b7937a68367088f3c1f7c334307422c71737b1d7

• Flags: Patch
• Epic Link: windows
• Assignee: Andrew Schwartzmeyer
• Reporter: Andrew Schwartzmeyer
• Shepherd: Alex Clemmer
• Created: 02/Dec/16 22:49
• Updated: 07/Dec/16 00:27
• Resolved: 07/Dec/16 00:27

Description

Error occurs at runtime due to runtime_dir initialization code in the CLI.
Code attempts to get the current user's name (which throws an error on Windows):

F1202 14:43:16.214303 9816 flags.cpp:215] CHECK_SOME(user): The request is not supported.

*** Check failure stack trace: ***

While https://reviews.apache.org/r/53706/ implements os::user, the default is still incorrect for Windows as it switches on the Linux user "root", and would cause the hard-coded Linux default to be used in the edge case of a user named "root" on Windows.

The fix is to use a proper Windows location for persistent data.

Issue Links

• is duplicated by: MESOS-6722 Agent tries to use POSIX paths for the variable data runtime directory.