[MESOS-6320] Implement clang-tidy check to catch incorrect flags hierarchies

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Labels: clang-tidy mesosphere
• Epic Link: clang-tidy
• Sprint: Mesosphere Sprint 49
• Story Points: 3
• Assignee: Benjamin Bannier
• Reporter: Benjamin Bannier
• Shepherd: Michael Park
• Created: 06/Oct/16 15:05
• Updated: 26/Mar/18 08:14
• Resolved: 24/Jan/17 20:19

Description

Classes need to always use virtual inheritance when being derived from FlagsBase. Also, in order to compose such derived flags they should be inherited virtually again.

Some examples:

struct A : virtual FlagsBase {}; // OK
struct B : FlagsBase {}; // ERROR
struct C : A {}; // ERROR

We should implement a clang-tidy checker to catch such wrong inheritance issues.