[MESOS-6295] Excessive logging on agent when oversubscription modules are attached

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Component/s: oversubscription
• Labels: module newbie
• Assignee: Unassigned
• Reporter: Kunal Thakar
• Shepherd: Joseph Wu
• Created: 30/Sep/16 17:41
• Updated: 01/Oct/16 01:08
• Resolved: 01/Oct/16 01:08

Description

The mesos agent is logging a INFO log in the agent that prints out the number of QoS corrections received from the module [1]. By default, this method gets called in a tight loop, which results in the logs getting flooded with noise.

mesos-slave[14591]: I0930 17:31:19.278774 14598 slave.cpp:5049] Received 0 QoS corrections
mesos-slave[14591]: I0930 17:31:19.280088 14602 slave.cpp:5049] Received 0 QoS corrections
mesos-slave[14591]: I0930 17:31:19.281497 14599 slave.cpp:5049] Received 0 QoS corrections
mesos-slave[14591]: I0930 17:31:19.282856 14614 slave.cpp:5049] Received 0 QoS corrections

Even after reducing the QoS checking frequency, this line does not make for a good INFO log as it is periodic. Can we change it to only log when there are non zero number of corrections received from the module? I can send a patch if this is acceptable.

[1] https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L5523