[MESOS-6216] LibeventSSLSocketImpl::create is not safe to call concurrently with os::getenv

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.2, 1.1.0
• Component/s: security
• Labels: mesosphere
• Target Version/s: 1.0.2, 1.1.0
• Sprint: Mesosphere Sprint 44
• Story Points: 5
• Assignee: Benjamin Bannier
• Reporter: Benjamin Bannier
• Shepherd: Till Toenshoff
• Created: 21/Sep/16 08:30
• Updated: 29/Apr/19 09:26
• Resolved: 07/Oct/16 13:18

Description

LibeventSSLSocketImpl::create is called whenever a potentially ssl-enabled socket is created. It in turn calls openssl::initialize which calls a function reinitialize using os::setenv. Here os::setenv is used to set up SSL-related libprocess environment variables LIBPROCESS_SSL_*.

Since os::setenv is not thread-safe just like the ::setenv it wraps, any calling of functions like os::getenv (or via os::environment) concurrently with the first invocation of LibeventSSLSocketImpl::create performs unsynchronized r/w access to the same data structure in the runtime.

We usually perform most setup of the environment before we start the libprocess runtime with process::initialize from a main function, see e.g., src/slave/main.cpp or src/master/main.cpp and others. It appears that we should move the setup of libprocess' SSL environment variables to a similar spot.

Issue Links

• is related to: MESOS-2407 libprocess segfaults when using GLOG_v=2