Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-6184

Health checks should use a general mechanism to enter namespaces of the task.

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Reviewable
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None

      Description

      To perform health checks for tasks, we need to enter the corresponding namespaces of the container. For now health check use custom clone to implement this

        return process::defaultClone([=]() -> int {
          if (taskPid.isSome()) {
            foreach (const string& ns, namespaces) {
              Try<Nothing> setns = ns::setns(taskPid.get(), ns);
              if (setns.isError()) {
                ...
              }
            }
          }
          return func();
        });
      

      After the childHooks patches merged, we could change the health check to use childHooks to call setns and make process::defaultClone private again.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                haosdent@gmail.com haosdent
                Shepherd:
                Alex R
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: