[MESOS-6184] Health checks should use a general mechanism to enter namespaces of the task.

• Type: Improvement
• Status: Reviewable
• Priority: Major
• Resolution: Unresolved
• Labels: check health-check mesosphere tech-debt
• Epic Link: TaskCheckingImprovements
• Sprint: Mesosphere Sprint 44, Mesosphere Sprint 46, Mesosphere Sprint 47
• Story Points: 3
• Assignee: Unassigned
• Reporter: haosdent
• Shepherd: Alex R
• Created: 16/Sep/16 15:28
• Updated: 06/Feb/18 12:28

Description

To perform health checks for tasks, we need to enter the corresponding namespaces of the container. For now health check use custom clone to implement this

  return process::defaultClone([=]() -> int {
    if (taskPid.isSome()) {
      foreach (const string& ns, namespaces) {
        Try<Nothing> setns = ns::setns(taskPid.get(), ns);
        if (setns.isError()) {
          ...
        }
      }
    }
    return func();
  });

After the childHooks patches merged, we could change the health check to use childHooks to call setns and make process::defaultClone private again.

Issue Links

• is blocked by: MESOS-6236 Launch subprocesses associated with specified namespaces.
• is related to: MESOS-7183 Always get coredump by add a health check on docker container app
• relates to: MESOS-8037 ns::clone should spawn process, which is a direct child
• relates to: MESOS-5070 Introduce more flexible subprocess interface for child options.