[MESOS-6158] Docker executor uses callback capturing this which isn't dispatched/deferred

• Type: Bug
• Status: Accepted
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.0.0
• Component/s: docker
• Labels: clang-tidy
• Assignee: Unassigned
• Reporter: Benjamin Bannier
• Created: 14/Sep/16 13:03
• Updated: 10/Oct/16 11:58

Description

Our custom clang-tidy checks identified the following use of this capture without dispatch / defer.

src/docker/executor.cpp:396:38: warning: callback capturing this should be dispatched/deferred to a specific PID [mesos-this-capture]
      .after(DOCKER_INSPECT_TIMEOUT, [=](const Future<Nothing>&) {
                                     ^

The issue here is that the stored callback modifies the member variable inspect, but is not tied to the instance's lifetime. In general such access can lead to data races, or in more extreme cases cause the callback to work on already cleaned up memory.