[MESOS-5913] Stale socket FD usage when using libevent + SSL.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.27.3, 0.28.2, 1.0.0
• Fix Version/s: 0.28.3, 1.0.1
• Component/s: libprocess
• Epic Link: SSL Tech Debt
• Assignee: Benjamin Mahler
• Reporter: Benjamin Mahler
• Created: 27/Jul/16 01:23
• Updated: 22/Mar/19 16:40
• Resolved: 28/Jul/16 23:36

Description

jgehrcke reported seeing garbage data being sent on sockets when hitting the master or agents with a lot of HTTP requests.

I was able to reproduce this locally by running HTTP requests while hammering the code with HTTPS requests.

Looking at the code, it appears that accepted SSL sockets may be used after they are closed (see here).

This code may call SSL_shutdown after Socket::~Impl closes the fd. This means that if the fd is re-used, we may accidentally write a TLS Alert message to the re-used fd.