Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-5903

`GTEST_IS_THREADSAFE` guards prevent many tests from being run on Windows.

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      In many tests, there is an assertion about the thread-safety of GTest, like: `ASSERT_TRUE(GTEST_IS_THREADSAFE)`.

      This prevents probably a dozen tests from getting run on Windows. In libprocess alone:

      • FutureTest: Select,
      • LimiterTest: Acquire
      • MetricsTest: Gauge, Snapshot, SnapshotTimeout, SnapshotAuthenticationEnabled
      • ProcessTest: Spawn, Dispatch, Defer1, Defer2, Defer3, Handlers, Expect, Action, Inheritance, Thunk, Delegate, Delay, Order, Donate, Settle, Pid, Listener, Executor, Remote, Async,

      Attachments

        Issue Links

        is related to

        Bug - A problem which impairs or prevents the functions of the product. MESOS-7193 Use of `GTEST_IS_THREADSAFE` in asserts is problematic.

        • Major - Major loss of function.
        • Resolved

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            nfnt Jan Schlicht
            hausdorff Alex Clemmer
            Neil Conway Neil Conway
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment