[MESOS-5882] `os::cloexec` does not exist on Windows

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Labels: mesosphere stout windows
• Sprint: Mesosphere Sprint 74, Mesosphere Sprint 75
• Story Points: 2
• Assignee: Andrew Schwartzmeyer
• Reporter: Andrew Schwartzmeyer
• Shepherd: Joseph Wu
• Created: 21/Jul/16 18:25
• Updated: 21/Feb/18 23:10
• Resolved: 21/Feb/18 23:10

Description

`os::cloexec` does not work on Windows. It will never work at the OS level. Because of this, there are likely many important and hard-to-detect bugs hanging around the agent.

This is extremely important to fix. Some possible solutions to investigate (some of which are extremely risky):

• Abstract out file descriptors into a class, implement cloexec in that class on Windows (since we can't rely on the OS to do it).
• Refactor all the code that relies on `os::cloexec` to not rely on it.

Of the two, the first seems less risky in the short term, because the cloexec code only affects Windows. Depending on the semantics of the implementation of the `FileDescriptor` class, it is possible that this is riskier to Windows in the longer term, as the semantics of `cloexec` may have subtle difference between Linux and Windows.

Issue Links

• is related to: MESOS-8563 Windows executors cannot re-register