Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-5331

Some cleanup in filesystem_isolator_tests.cpp

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.0.0
    • None
    • None

    Description

      There are some issues in filesystem_isolator_tests.cpp and need some clean up to make sure when we want to make a reference to this file, we can get the right coding style.

      The issues are as following:

      1) The filesystem_isolator_tests.cpp was already wrapped in OS_LINUX in the makefile, there is no need to define the "_linux_" marco anymore for this test.
      2) Some unused variables, such as containerId and slaveId
      3) We should avoid using 'using namespace' but include them explicitly.
      4) Update indent for some functions.
      5) Replace ".get().xxx" with "->xxx".

      The file of runtime_isolator_tests.cpp should also have the _linux_ removed as this file was also wrapped in OS_LINUX in the makefile.

      Attachments

        Activity

          People

            gyliu Guangya Liu
            gyliu Guangya Liu
            Jie Yu Jie Yu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: