[MESOS-5224] buffer overflow error in slave upon processing malformed UUIDs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.28.0
• Fix Version/s: 1.0.0
• Component/s: agent
• Labels: mesosphere

Environment

$ dpkg -l|grep -e mesos
ii  mesos                               0.28.0-2.0.16.ubuntu1404         amd64        Cluster resource manager with efficient resource isolation
$ uname -a
Linux node-3 3.13.0-29-generic #53-Ubuntu SMP Wed Jun 4 21:00:20 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

• Epic Link: Executor API v1 improvements
• Assignee: deshna jain
• Reporter: James DeFelice
• Shepherd: Vinod Kone
• Created: 17/Apr/16 18:03
• Updated: 13/Jan/17 16:58
• Resolved: 20/Jun/16 22:48

Description

implementing support for executor HTTP v1 API in mesos-go:next and my executor can't send status updates because the slave dies upon receiving them. protobufs generated from 0.28.1

from syslog:

Apr 17 17:53:53 node-1 mesos-slave[4462]: I0417 17:53:53.121467  4489 http.cpp:190] HTTP POST for /slave(1)/api/v1/executor from 10.2.0.5:51800 with User-Agent='Go-http-client/1.1'
Apr 17 17:53:53 node-1 mesos-slave[4462]: *** buffer overflow detected ***: /usr/sbin/mesos-slave terminated
Apr 17 17:53:53 node-1 mesos-slave[4462]: ======= Backtrace: =========
Apr 17 17:53:53 node-1 mesos-slave[4462]: /lib/x86_64-linux-gnu/libc.so.6(+0x7338f)[0x7fc53064e38f]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /lib/x86_64-linux-gnu/libc.so.6(__fortify_fail+0x5c)[0x7fc5306e5c9c]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /lib/x86_64-linux-gnu/libc.so.6(+0x109b60)[0x7fc5306e4b60]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /usr/local/lib/libmesos-0.28.0.so(_ZN5mesos8internallsERSoRKNS0_12StatusUpdateE+0x16a)[0x7fc531cc617a]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /usr/local/lib/libmesos-0.28.0.so(_ZN5mesos8internal5slave5Slave12statusUpdateENS0_12StatusUpdateERK6OptionIN7process4UPIDEE+0xe7)[0x7fc531d71837]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /usr/local/lib/libmesos-0.28.0.so(_ZNK5mesos8internal5slave5Slave4Http8executorERKN7process4http7RequestE+0xb52)[0x7fc531d302a2]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /usr/local/lib/libmesos-0.28.0.so(+0xc754a3)[0x7fc531d4d4a3]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /usr/local/lib/libmesos-0.28.0.so(+0x1295aa8)[0x7fc53236daa8]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /usr/local/lib/libmesos-0.28.0.so(_ZN7process14ProcessManager6resumeEPNS_11ProcessBaseE+0x2d1)[0x7fc532375a71]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /usr/local/lib/libmesos-0.28.0.so(+0x129dd77)[0x7fc532375d77]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /usr/lib/x86_64-linux-gnu/libstdc++.so.6(+0xb1bf0)[0x7fc530e85bf0]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /lib/x86_64-linux-gnu/libpthread.so.0(+0x8182)[0x7fc5309a8182]
Apr 17 17:53:53 node-1 mesos-slave[4462]: /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x7fc5306d547d]
...
Apr 17 17:53:53 node-1 mesos-slave[4462]: *** Aborted at 1460915633 (unix time) try "date -d @1460915633" if you are using GNU date ***
Apr 17 17:53:53 node-1 mesos-slave[4462]: PC: @     0x7fc530611cc9 (unknown)
Apr 17 17:53:53 node-1 mesos-slave[4462]: *** SIGABRT (@0x116e) received by PID 4462 (TID 0x7fc5275f5700) from PID 4462; stack trace: ***
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc5309b0340 (unknown)
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc530611cc9 (unknown)
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc5306150d8 (unknown)
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc53064e394 (unknown)
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc5306e5c9c (unknown)
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc5306e4b60 (unknown)
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc531cc617a mesos::internal::operator<<()
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc531d71837 mesos::internal::slave::Slave::statusUpdate()
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc531d302a2 mesos::internal::slave::Slave::Http::executor()
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc531d4d4a3 _ZNSt17_Function_handlerIFN7process6FutureINS0_4http8ResponseEEERKNS2_7RequestEEZN5mesos8internal5slave5Slave10initializeEvEUlS7_E19_E9_M_invokeERKSt9_Any_dataS7_
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc53236daa8 _ZZN7process11ProcessBase5visitERKNS_9HttpEventEENKUlRKNS_6FutureI6OptionINS_4http14authentication20AuthenticationResultEEEEE0_clESC_
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc532375a71 process::ProcessManager::resume()
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc532375d77 _ZNSt6thread5_ImplISt12_Bind_simpleIFSt5_BindIFZN7process14ProcessManager12init_threadsEvEUlRKSt11atomic_boolE_St17reference_wrapperIS6_EEEvEEE6_M_runEv
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc530e85bf0 (unknown)
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc5309a8182 start_thread
Apr 17 17:53:53 node-1 mesos-slave[4462]:     @     0x7fc5306d547d (unknown)

Issue Links

• is related to: MESOS-6917 Segfault when the executor sets an invalid UUID when sending a status update.
• relates to: MESOS-6920 Validate the UUID in Master::statusUpdate.