Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-5162

Commit message hook behaves incorrectly when a message includes a "*".

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.0.0
    • None
    • Mesosphere Sprint 33
    • 2

    Description

      If there is a "*" in a commit message (there often is when we have bulleted lists), due to the current use of echo $LINE, the $LINE gets expanded with a "*" in it, which becomes a matcher in bash and therefore subsequently gets expanded into the list of files/directories in the current directory.

      In order to avoid this mess, we need to wrap such variables in quotes, like so: echo "$LINE".

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mcypark Michael Park
            mcypark Michael Park
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Agile

                Completed Sprint:
                Mesosphere Sprint 33 ended 27/Apr/16
                View on Board

                Slack

                  Issue deployment