Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-4979

os::rmdir does not handle special files (e.g., device, socket).

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.19.0, 0.20.0, 0.21.0, 0.22.0, 0.23.0, 0.24.0, 0.25.0, 0.26.0, 0.27.0, 0.27.1, 0.27.2
    • Fix Version/s: 0.24.2, 0.25.1, 0.26.1, 0.27.3, 0.28.0
    • Component/s: stout

      Description

      Stout os::rmdir does not handle special files like device files or socket files. This could cause failures when GC sandboxes.

        Issue Links

          Activity

          Hide
          jieyu Jie Yu added a comment -

          commit 5278e5cc50544ed7af28b15a1acd2b2e96a15a47
          Author: Jojy Varghese <jojy@mesosphere.io>
          Date: Tue Mar 15 17:12:01 2016 -0700

          Added support for FTS_SLNONE in rmdir.

          Review: https://reviews.apache.org/r/44874/

          commit 5c4b348c8090ce61804b7701e3b0705ced975a7e
          Author: Jojy Varghese <jojy@mesosphere.io>
          Date: Tue Mar 15 17:11:54 2016 -0700

          Added test for rmdir with device file.

          Existing tests did not cover the case of removing directories with
          special files like device files.

          Review: https://reviews.apache.org/r/44873/

          commit f8b7ac28b1a918864a06b3f99f45b0257c7b6f68
          Author: Jojy Varghese <jojy@mesosphere.io>
          Date: Tue Mar 1 14:32:13 2016 -0800

          Added FS_DEFAULT case in rmdir.

          We currently dont handle special files like device files in rmdir. This
          change adds FS_DEFAULT as one of the cases where we try to unlink a
          file. Reference: http://man7.org/linux/man-pages/man3/fts.3.html

          Review: https://reviews.apache.org/r/44230/

          Show
          jieyu Jie Yu added a comment - commit 5278e5cc50544ed7af28b15a1acd2b2e96a15a47 Author: Jojy Varghese <jojy@mesosphere.io> Date: Tue Mar 15 17:12:01 2016 -0700 Added support for FTS_SLNONE in rmdir. Review: https://reviews.apache.org/r/44874/ commit 5c4b348c8090ce61804b7701e3b0705ced975a7e Author: Jojy Varghese <jojy@mesosphere.io> Date: Tue Mar 15 17:11:54 2016 -0700 Added test for rmdir with device file. Existing tests did not cover the case of removing directories with special files like device files. Review: https://reviews.apache.org/r/44873/ commit f8b7ac28b1a918864a06b3f99f45b0257c7b6f68 Author: Jojy Varghese <jojy@mesosphere.io> Date: Tue Mar 1 14:32:13 2016 -0800 Added FS_DEFAULT case in rmdir. We currently dont handle special files like device files in rmdir. This change adds FS_DEFAULT as one of the cases where we try to unlink a file. Reference: http://man7.org/linux/man-pages/man3/fts.3.html Review: https://reviews.apache.org/r/44230/

            People

            • Assignee:
              jojy Jojy Varghese
              Reporter:
              jieyu Jie Yu
              Shepherd:
              Jie Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development