[MESOS-4693] Variable shadowing in HookManager::slavePreLaunchDockerHook

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.27.0
• Fix Version/s: 0.27.2, 0.28.0
• Component/s: modules
• Assignee: Kevin Devroede
• Reporter: Kevin Devroede
• Shepherd: Kapil Arya
• Created: 17/Feb/16 16:33
• Updated: 29/Apr/19 09:26
• Resolved: 27/Feb/16 04:35

Description

It looks like the name parameter in HookManager::slavePreLaunchDockerHook is shadowed by the hook name defined in the foreach (const string& name, availableHooks.keys()).

Due to this, the hook receives its own name as a parameter instead of the container name. It seems to be the only method of HookManager affected by this shadowing.

See: https://github.com/apache/mesos/blob/0.27.0/src/hook/manager.cpp#L203

If that's really a bug, I'd be happy to submit a patch.